<font size="2"><font face="tahoma,sans-serif">Hi;<br></font></font><br><div class="gmail_quote">On Sat, Jun 25, 2011 at 6:21 PM,  <span dir="ltr"><<a href="mailto:jbowler@acm.org">jbowler@acm.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="EN-US" link="blue" vlink="purple"><div><div><div><p class="MsoNormal"><b><span style="font-size:10.0pt">From:</span></b><span style="font-size:10.0pt"> İsmail Dönmez [mailto:<a href="mailto:ismail@namtrac.org" target="_blank" title="[GMCP] Compose a new mail to ismail@namtrac.org" onclick="window.open('https://mail.google.com/mail/u/0/?view=cm&fs=1&tf=1&to=ismail@namtrac.org','Compose new message','width=640,height=480');return false" rel="noreferrer">ismail@namtrac.org</a>] <br>

</span></p><div class="im"><span style="color:#1F497D">></span>So you mean ifdef is correct here?<span style="color:#1F497D"><u></u><u></u></span></div><p></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">I’m saying it *<b>should</b>* be correct in zlib-1.2.5 and *<b>was not</b>* correct in zlib-1.2.4.<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">However I think that in fact the patch never made it to 1.2.5; see this thread:<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> </span></p>

</div></div></div></div></blockquote><div><br></div><div>Well so it never made it then, thats my point ;) Mark, can you comment on the correctness of this please? I'd like to have Android guys fix this too.</div><div>

<br></div><div>Regards.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="EN-US" link="blue" vlink="purple"><div><div><div><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u></span></p>

<p>From: <a href="mailto:zlib-devel-bounces@madler.net" target="_blank" title="[GMCP] Compose a new mail to zlib-devel-bounces@madler.net" onclick="window.open('https://mail.google.com/mail/u/0/?view=cm&fs=1&tf=1&to=zlib-devel-bounces@madler.net','Compose new message','width=640,height=480');return false" rel="noreferrer">zlib-devel-bounces@madler.net</a> [mailto:<a href="mailto:zlib-devel-bounces@madler.net" target="_blank" title="[GMCP] Compose a new mail to zlib-devel-bounces@madler.net" onclick="window.open('https://mail.google.com/mail/u/0/?view=cm&fs=1&tf=1&to=zlib-devel-bounces@madler.net','Compose new message','width=640,height=480');return false" rel="noreferrer">zlib-devel-bounces@madler.net</a>] On Behalf Of Pierre Schmitz<br>

Sent: Thursday, May 27, 2010 3:19 PM<br>To: <a href="mailto:zlib-devel@zlib.net" target="_blank" title="[GMCP] Compose a new mail to zlib-devel@zlib.net" onclick="window.open('https://mail.google.com/mail/u/0/?view=cm&fs=1&tf=1&to=zlib-devel@zlib.net','Compose new message','width=640,height=480');return false" rel="noreferrer">zlib-devel@zlib.net</a><br>

Subject: [Zlib-devel] zlib-1.2.5-lfs-decls.patch<u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">So I think this patch (which is identical to what you suggest):<u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p><p><a href="http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-libs/zlib/files/zlib-1.2.5-lfs-decls.patch?view=markup" target="_blank">http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-libs/zlib/files/zlib-1.2.5-lfs-decls.patch?view=markup</a><u></u><u></u></p>

<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Still needs to be applied to 1.2.5<u></u><u></u></span></p><p class="MsoNormal">

<span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">After examining the code I believe that zlib built on a 64-bit system with LFS64 support does not work unless the app defines _<i>LARGEFILE64</i>_SOURCE.  (That’s not a work-round, if the app defines that it changes all the header files.)<u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">I run Gentoo, so my 1.2.5 zlib.h does have the patch ;-)<u></u><u></u></span></p>

<div class="im"><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">John Bowler <a href="mailto:jbowler@acm.org" target="_blank" title="[GMCP] Compose a new mail to jbowler@acm.org" onclick="window.open('https://mail.google.com/mail/u/0/?view=cm&fs=1&tf=1&to=jbowler@acm.org','Compose new message','width=640,height=480');return false" rel="noreferrer">jbowler@acm.org</a><u></u><u></u></span></p>

<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><u></u> <u></u></span></p></div></div></div></div></div></blockquote></div><br>