[Zlib-devel] TR: zlib 1.2.4 released

[Gilles Vollant]

this mean that the better solution is adding "a day" in zconf.h anything like


#if (defined(_MSC_VER)) && defined(_LARGEFILE64_SOURCE))
#define z_off64_t __int64
#endif


BUT with my solution (which need no source modification), you are sure that the DLL  *64 function are good (and not linked to a 32 bits function), so we don't need remove the .def in zlib 1.2.4.

So I suggest :
- on zlib 1.2.4, don't remove the *64 function in .def but use my define. So the *64 function will be linked to real 64 bits function in the DLL, and we don't need remove them from .def
- on next zlib, adding a good z_off64_t solution compatible with all compiler...

another tips for future : merging this 64 bits question between main zlib and gz*.? and contrib/minizip/ioapi.h

-----Message d'origine-----
De : William A. Rowe Jr. [mailto:wrowe at rowe-clan.net] 
Envoyé : samedi 13 mars 2010 00:13
À : Gilles Vollant
Cc : 'Mark Adler'; zlib-devel at madler.net
Objet : Re: TR: [Zlib-devel] zlib 1.2.4 released

On 3/12/2010 5:05 PM, Gilles Vollant wrote:
> my solution in just adding on line "WFLAGS  =" of  makefile.msc

That is a solution to build the library.  It is not a reasonable solution
for consumers of the library.  It is a big distinction.

Defining z_off64_t in zconf.h, for all users to be able to portably consume
the gz*64 API, is the way to go for consumers.